Handle empty feedback #23554
Merged
Handle empty feedback #23554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Jul 6, 2018
aoby
reviewed
Jul 6, 2018
| sign_in @teacher | ||
| get "#{API}/get_feedback_from_teacher", params: {student_id: @student.id, level_id: @level.id, teacher_id: @teacher.id} | ||
|
|
||
| assert_response 204 |
There was a problem hiding this comment.
nit: maybe :no_content here instead of 204 for consistency? Not a big deal either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that breaks out the additional edge case handling for when the teacher_feedbacks controller tries to get feedback when there is none.
[Model] The
latestscope returns nil when there is no feedback.[Model] (No Change) The 'latest_by_teacher' scope returns [] when there is no feedback.
[Controller] The (singular)
get_feedback_from_teacherreturns no_content when there is no feedback.[Controller] (No Change) The (collection)
get_feedbacksreturns [] when there is no feedback.Tests included.
Note: I made no change to the way the empty feedback is handled for the collection (
latest_by_teacherandget_feedbacks), since the [] makes sense in this case and allows the UI to easy handle displaying nothing.