Thanks donors on twitter from hoc.com #23561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
approved these changes
Jul 6, 2018
|
cc @wjordan incase I'm missing something unexpected. |
|
iirc, these pages should be cached in Varnish which makes the DB hit pretty negligible, though it means a random selection goes to a lot of people until a fresh copy of the page is generated. |
|
Oh yeah, you're right there are no share buttons for the video on the homepage. Thanks for doing this. I would normally give your PR an emoji reaction to let you know I approve, but none of them felt right. lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tanyaparker I didn't see a twitter share on the homepage, but it should be easy to add later if needed.