Teacher feedback - No_ie follow-up #23563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to this PR: #23486
After investigating, it looks like there are persistent issues with using 'I press keys' steps in IE. However, this step was a solution needed in order to trigger the onChange event associated with the text input for other browsers. This PR scopes down the @no_ie to just the test that fails and adds an explanatory comment. I'm submitting this as the 'current-final' solution to this test failing in IE, with no immediate plans to follow up. I tested manually in IE in SauceLabs to ensure functionality. Additionally, when this feature is released widely and the current stable-external-temporary landing page removed, this test file will be refactored to remove the stable-external-temp tests. It is my plan to break-up this large test at that point, further scoping down the impact of the @no_ie flag.