Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add google jsapi script for export scenario #23573

Merged
merged 1 commit into from Jul 11, 2018
Merged

add google jsapi script for export scenario #23573

merged 1 commit into from Jul 11, 2018

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Jul 9, 2018

  • In order to support drawChart() and the related charts functionality in applab exports, we need to pull in the google jsapi script. Note, this won't work while offline since the charts are cloud-rendered.

@cpirich cpirich requested a review from islemaster July 9, 2018 17:50
islemaster
islemaster approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cpirich cpirich merged commit fff8152 into staging Jul 11, 2018
@cpirich cpirich deleted the applab_export_google_charts branch July 11, 2018 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpirich @islemaster