PD: international opt-in additional work #23603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Jul 10, 2018
aoby
reviewed
Jul 10, 2018
| assert_response :forbidden | ||
| end | ||
|
|
||
| assert_response :forbidden |
aoby
reviewed
Jul 10, 2018
| assert_response :redirect | ||
| end | ||
|
|
||
| assert_response :redirect |
Since the link to sign-up doesn't go to sign-up when the user is already signed in.
|
This PR is now ready for review. |
aoby
approved these changes
Jul 13, 2018
tanyaparker
approved these changes
Jul 16, 2018
dashboard/config/locales/en.yml
Outdated
| @@ -1041,7 +1041,7 @@ en: | |||
| workshop_organizer: 'Workshop Organizer' | |||
| workshop_facilitator: 'Workshop Facilitator' | |||
| workshop_course: 'Workshop Course' | |||
| email_opt_in: 'I agree that Code.org can share my contact information and aggregate data about my classes with the Code.org International Partner in my country.' | |||
| email_opt_in: 'Can we email you about Code.org’s international program, updates to our courses, or other computer science news? (See our privacy policy)' | |||
There was a problem hiding this comment.
Is the privacy policy linked here? If we can't do links within this string, I'd prefer if (See our privacy policy) was a separate, linked string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #23235.