Assessments tab: Prevent errors in assessments APIs returns #23615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Jul 10, 2018
| @@ -73,7 +73,8 @@ export const asyncLoadAssessments = (sectionId, scriptId) => { | |||
| const state = getState().sectionAssessments; | |||
|
|
|||
| // Don't load data if it's already stored in redux. | |||
| if (state.assessmentResponsesByScript[scriptId]) { | |||
| // Don't attempt to load data if there is not script or section selected. | |||
| if (state.assessmentResponsesByScript[scriptId] || !scriptId || !sectionId) { | |||
There was a problem hiding this comment.
apologies if this is just a nit, but the comment says "if there is not a script OR section selected" but the code appears to implement "if there is not a script AND section selected". I'm not sure which is correct, but they should probably be consistent
maddiedierker
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors you saw yesterday were happening because we were missing a translation and therefore couldn't select a default script. While this shouldn't happen, if it does, the APIs on the assessments tab will fail because they require a scriptId. This will prevent us from making those requests that we know will fail and instead show the UI having no assessments available.