Move controller helper method into model and call with safe navigation... #23616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n operator to prevent null error
mehalshah
approved these changes
Jul 11, 2018
| future_or_current_teachercon_or_fit?(enrollment.workshop) | ||
| end | ||
| enrollments = ::Pd::Enrollment.for_user(current_user).all.reject do |enrollment| | ||
| enrollment.workshop&.future_or_current_teachercon_or_fit? |
There was a problem hiding this comment.
I'm surprised this is needed - workshops delete their enrollments when they are deleted. Do we know what happened here?
There was a problem hiding this comment.
Agreed. This is surprising. Perhaps an anomaly, from some manual intervention?
The models in question are enrollment id 1460 (created 2016-06-21), and workshop id 292 (created 2016-06-21, deleted 2017-01-06).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…operator to prevent null error
See https://app.honeybadger.io/projects/3240/faults/38563701#notice-summary
This user has an old enrollment for a workshop which was deleted (on 2017-01-06).