Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CSF: supply list includes headphones and removed school year i… #23631

Merged
merged 1 commit into from Jul 11, 2018

Conversation

tanyaparker
Copy link
Contributor

@tanyaparker tanyaparker commented Jul 11, 2018

…n exit survey

The exit survey has a question that asks about teaching the course in the 2017-18 school year, which is now outdated. Is it ok to just say "next" so that we don't have to update this each year? Or do we track it separately each year to know how many people said yes to 2017, 2018, etc. If so, I can use Ruby time or something...

Andrew, does updating this label break how we store the data or show the results? I didn't see this question reflected in the survey results page.

image

@bencodeorg
Copy link
Contributor

Seems fine to me, can use the submission date to infer what school year they're talking about?

@tanyaparker
Copy link
Contributor Author

Oh yeah, totally.

Copy link
Contributor

@aoby aoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is just a label, not stored. It's fine to change, and we can get the year from the associated workshop and/or submission date.

@tanyaparker tanyaparker merged commit bf5e47e into staging Jul 11, 2018
@tanyaparker tanyaparker deleted the csf-workshop-details branch July 11, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants