Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #23625 I noticed some things I don't like about our
Button
component, so I'm changing them. I've also updated the storybook entry for Buttons to be more browsable.This will cause eyes changes.
Before
(Disabled)
disabled
prop and anhref
prop is still a clickable link.After
(Disabled)
font-weight: bold
for readability.disabled
prop and anhref
prop does nothing when clicked.