Create Route to Put Assets #23678
Merged
Create Route to Put Assets #23678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Jul 13, 2018
shared/middleware/files_api.rb
Outdated
| @@ -374,11 +374,11 @@ def copy_file(endpoint, encrypted_channel_id, filename, source_filename) | |||
| end | |||
|
|
|||
| # | |||
| # PUT /v3/sources/<channel-id>/<filename>?version=<version-id> | |||
| # PUT /v3/(sources|assets)/<channel-id>/<filename>?version=<version-id> | |||
There was a problem hiding this comment.
Passing a version parameter with to the assets API might not go well - I'd consider breaking this comment into two lines, so the assets case clearly doesn't support the version parameter, and also adding a unit test for trying to pass a version when uploading an asset. I think the ideal behavior would be to just ignore the parameter in that case.
shared/test/test_assets.rb
Outdated
| response = @api.put_object(sound_filename, sound_body, {'CONTENT_TYPE' => 'json'}) | ||
| actual_sound_info = JSON.parse(response) | ||
| expected_sound_info = {'filename' => sound_filename, 'category' => 'audio', 'size' => sound_body.length} | ||
| assert_fileinfo_equal(expected_sound_info, actual_sound_info) |
There was a problem hiding this comment.
Additional test ideas:
- PUT to the same filename again and verify that the object is replaced (rather than failing or making a second object), to show the appropriate idempotent behavior.
- PUT to a second filename and verify the API can handle different files being uploaded (would catch accidentally hard-coded filename values, etc).
|
How are we moderating these new file types? |
|
@joshlory I'm not sure I understand what you are asking, can you explain what you mean? If you are asking about content moderation, then according to the spec, we are limiting audio recording to 1 minute in length as a means of moderation. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test.
This route is being added to handle audio that is recorded by the student in the browser and then sent to the assets in S3.
I went back and forth quite a bit deciding whether this route should be a 'put' or 'post' and would love input on whether using a 'put' makes sense in this situation.
Additionally, any feedback on additional tests I should include to ensure full coverage would be appreciated. Thanks!