Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cucumber to v3.1.1 #23687

Merged
merged 2 commits into from Jul 17, 2018
Merged

update cucumber to v3.1.1 #23687

merged 2 commits into from Jul 17, 2018

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Jul 13, 2018

No description provided.

@wjordan wjordan requested a review from islemaster July 17, 2018 17:18
islemaster
islemaster approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Any particular improvements you're hoping to take advantage of after this upgrade?

@wjordan
Copy link
Contributor Author

wjordan commented Jul 17, 2018

no particular improvements, just keeping up to date with the latest. Partially to ensure that if we try out changes forked from github, we can base off master rather than an old tag. If it happens to fix the truncated-output issue, that would be great, but not expecting it to.

@wjordan wjordan merged commit 077840c into staging Jul 17, 2018
@wjordan wjordan deleted the cucumber_update branch July 17, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjordan @islemaster