Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary action column styles in ManageLinkedAccounts #23711

Merged
merged 1 commit into from Jul 17, 2018

Conversation

maddiedierker
Copy link
Contributor

This fixes some wonky-looking styles on the "Actions" column in ManageLinkedAccounts. I added some flexbox to that column that messed up other styles and ended up being mostly unnecessary, so this removes those styles.

Before

The tooltip isn't centered on the "Disconnect" button and there is an extra layer of border (not totally sure why adding display: flex; made that happen...):
screen shot 2018-07-13 at 2 44 44 pm

After

Without an error:
screen shot 2018-07-13 at 4 14 34 pm

With an error:
screen shot 2018-07-13 at 4 14 20 pm

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when the solution is "less code."

@maddiedierker maddiedierker merged commit 62512b1 into staging Jul 17, 2018
@maddiedierker maddiedierker deleted the linked-accounts-ui-bug branch July 17, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants