Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessments Tab: rename components #23724

Merged
merged 6 commits into from Jul 16, 2018
Merged

Conversation

caleybrock
Copy link
Contributor

@caleybrock caleybrock commented Jul 16, 2018

In a PR a while ago @Erin007 asked about MC vs MultipleChoice naming consistency.

This PR makes those names consistent as well as the order of table and container names.
Names are now like this:
Part 1: question type, eg FreeResponses or MultipleChoice
Part 2: what its for, eg Assessments or Survey
Part 3: type of component, eg Table or Container

Everything's a lot easier to follow when they are consistent like this.

screen shot 2018-07-16 at 11 20 59 am

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! Thank you. This is really clear now.

@caleybrock caleybrock merged commit 4f572fd into staging Jul 16, 2018
@caleybrock caleybrock deleted the rename-assessments-files branch July 16, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants