Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Tab UI tests #23752

Merged
merged 9 commits into from Jul 27, 2018
Merged

Progress Tab UI tests #23752

merged 9 commits into from Jul 27, 2018

Conversation

caleybrock
Copy link
Contributor

I removed the angular set of UI tests when removing the angular code. This adds back those tests with some updates to make them work with the new react views.

This really only tests the progress tab, and that you can switch between all tabs on the teacher dashbaord.

TODOs:

  • remove ?no_home_redirect=1 everywhere in code. there's no reason to have it now that we have a new dashboard.
  • add additional steps/checks for each of the additional tabs

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, thanks for resurrecting these!

@@ -145,6 +145,7 @@ class VirtualizedSummaryView extends Component {
styleTopRightGrid={progressStyles.topRight}
width={styleConstants['content-width']}
onScroll={onScroll}
id={"#uitest-summary-view"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove #

@caleybrock
Copy link
Contributor Author

This test is passing consistently on ChromeDriver and SauceConnect ChromeLatestWin7, but has failed 3 times in circle. Going to start a separate PR for debug purposes, but since the iteration time is going to be much longer, I'm guessing we'll be without UI tests on teacher dashboard until the end of the week.

@caleybrock
Copy link
Contributor Author

Gotten past loading the dropdown by seeding the express course.

Now timing out on And I wait until element "#uitest-summary-view" is visible
I can reproduce this behavior locally by returning a 403 with either the section_level_progress api or the script_structure api. So for some reason the user does not have permission to access the section (which doesn't make a ton of sense) or the script, which could be possible?

@caleybrock
Copy link
Contributor Author

I'm going to remove part of this test and just merge the parts that actually work. Here's what I'm removing:

And I wait until element "#uitest-summary-view" is visible
And I click selector "#uitest-toggle-detail-view" once I see it
And I wait until element "#uitest-detail-view" is visible
And I wait until element "a[href*='/s/allthethings/stage/2/puzzle/1']" is in the DOM
# Completed bubble is green
Then element "a[href*='/s/allthethings/stage/2/puzzle/1'] .uitest-bubble" has css property "background-color" equal to "rgb(14, 190, 14)"
# Not started bubble is gray
Then element "a[href*='/s/allthethings/stage/2/puzzle/2'] .uitest-bubble" has css property "background-color" equal to "rgb(254, 254, 254)"

@caleybrock caleybrock merged commit 66b71cd into staging Jul 27, 2018
@caleybrock caleybrock deleted the teacher-dash-ui-tests branch July 27, 2018 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants