Projects: Remove references to migratedToS3 #23820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Jul 20, 2018
There was a problem hiding this comment.
If you want to make sure this never comes back up on developer or adhoc machines, it would be best to null out this migration too: https://github.com/code-dot-org/code-dot-org/blob/staging/pegasus/migrations/076_migrate_channel_sources_to_s3.rb
AFAIK the setup process for developers involves running all migrations, and this one sets value['migratedToS3'].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upcoming work, we'd like to remove
migratedToS3from the value column of the storage_apps table. As a small first step, I'm removing the references tomigratedToS3from our codebase to ensure there isn't any code depending on that field.