always set assigned_at when assigning student to section #23860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
bug report: https://codeorg.axosoft.com/viewitem?id=1474&type=features&force_use_number=true
Description
always set
UserScript.assigned_atwhen assigning student to section. this causes the most recently assigned section to show up as the user's primary course. The primary course is what we redirect the student to on sign-in, and is the highlighted course on /home for students and teachers.Collateral Damage
None, AFAIK. I don't see any other places that assigned_at is surfaced in the product besides those listed above. @bencodeorg and @poorvasingal have also confirmed that we shouldn't be relying on the old behavior anywhere.