Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display DropdownButton menu on top of ProgressBubble #23864

Merged
merged 2 commits into from Jul 23, 2018

Conversation

davidsbailey
Copy link
Member

Background

the "assign" menu for teachers has been appearing behind progress bubbles, as described in https://codeorg.axosoft.com/viewitem?id=1441&type=features&force_use_number=true .

The ProgressBubble has a high z-index so that its tooltip appears on top of other things, as explained in #19538 and here:

// ReactTooltip sets a zIndex of 999. However, because in some cases for us
// the ReactTooltip is inside of a rotated div, it ends up in a different
// stacking context, and the zIndex doesn't work. Instead we set it here on
// the top component
zIndex: 999,

Description

Increase the z-index of the DropdownButton to more than that of the ProgressBubble . While we're at it, also increase the z-index of the teacher panel to make that appear on top of ProgressBubble too (see screenshots).

Screenshots

before
screen shot 2018-07-23 at 11 17 05 am

after
screen shot 2018-07-23 at 11 15 19 am

@davidsbailey davidsbailey merged commit 6f321d7 into staging Jul 23, 2018
@davidsbailey davidsbailey deleted the dropdown-button-menu branch July 23, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants