Projects: No personal projects yet message #23876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
changed the title
| @@ -16,32 +16,30 @@ export function generateFakePersonalProjects(n) { | |||
|
|
|||
| export const stubFakePersonalProjectData = [ | |||
| { | |||
| projectName: "Personal Project 1", | |||
| name: "Personal Project 1", | |||
There was a problem hiding this comment.
just curious -- why did projectName and isPublished change to name and publishedAt?
There was a problem hiding this comment.
I set up the Storybook data first, then fetched the real data in #23755 where I changed the field names. This just makes them consistent.
maddiedierker
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has not created any projects, we show a little message encouraging them to make some in the new React
PersonalProjectsTable. This is consistent with the current behavior in the Angular version of the table.This PR also includes a few updates to make the fake projects data for Storybook consistent with real projects data.