Report total download size to newrelic #23877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlory
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Nice! Looks like performance.getEntriesByType() is expected to work in Chrome, Firefox, Edge & IE — that's more browsers than I was expecting 👍.
joshlory
reviewed
Jul 24, 2018
| @@ -125,6 +125,7 @@ export default function (app, levels, options) { | |||
| next(); | |||
| } | |||
| } | |||
| logToCloud.reportPageSize(); | |||
There was a problem hiding this comment.
Out of curiosity, what types of things do we log to New Relic vs. AWS Firehose?
There was a problem hiding this comment.
I don't know if we have a general rule. In this case, the rest of the performance data I'm using is already in NewRelic, so I decided to log page sizes there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.