Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Courses: international users see grade blocks for en courses #23902

Merged
merged 2 commits into from Jul 25, 2018
Merged

Courses: international users see grade blocks for en courses #23902

merged 2 commits into from Jul 25, 2018

Conversation

breville
Copy link
Member

@breville breville commented Jul 25, 2018 •
edited

screenshot 2018-07-25 11 51 41

And whole non-en page:

localhost-studio code org_3000_courses ipad pro 3

@Erin007
Copy link
Contributor

Erin007 commented Jul 25, 2018

Is there a distinction between (English) for the course blocks and (English only) for the tools? If not, we should probably pick one and be consistent.

tanyaparker
tanyaparker approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@tanyaparker tanyaparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the copy updates! That resolves Erin's open question.

@breville breville merged commit 6a60042 into staging Jul 25, 2018
@breville breville deleted the courses-international-grade-bands branch July 25, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyaparker tanyaparker tanyaparker approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@breville @Erin007 @tanyaparker