Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model for Dance Lab #23905

Merged
merged 2 commits into from Jul 25, 2018
Merged

Add model for Dance Lab #23905

merged 2 commits into from Jul 25, 2018

Conversation

joshlory
Copy link
Contributor

New level type should default-load the DanceLab library and blocks.

@joshlory joshlory requested a review from balderdash July 25, 2018 01:40
balderdash
balderdash approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@balderdash balderdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to unblock dancelab progress.

Since this just selects a library and block pool, is there a plan to convert this to a 100% levelbuilder-editable GamelabJr subtype?

@joshlory
Copy link
Contributor Author

I think so. Until we know what the "new universe" workflow looks like.

@joshlory joshlory merged commit 9780fcc into staging Jul 25, 2018
@joshlory joshlory deleted the dance-lab branch July 25, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balderdash balderdash balderdash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlory @balderdash