Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rostered delete bug #23916

Merged
merged 3 commits into from Jul 25, 2018
Merged

Fix rostered delete bug #23916

merged 3 commits into from Jul 25, 2018

Conversation

maddiedierker
Copy link
Contributor

Follow-up to #23884. Students in rostered sections should be deleted when teacher deletes their account (with some exclusions, laid out below).

Rules around this

A student in a rostered section should be deleted when their teacher deletes their account if...

  • The student is migrated and has only 1 authentication option (if they are in a rostered section, we assume their single authentication option is for the login type of the rostered section)
  • The student is not migrated and does not have a password

islemaster
islemaster approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@maddiedierker maddiedierker merged commit 3e7ecfc into staging Jul 25, 2018
@maddiedierker maddiedierker deleted the fix-rostered-delete-bug branch July 25, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @islemaster