Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher Feedback - Style Fixes #23924

Merged
merged 3 commits into from Jul 26, 2018
Merged

Conversation

epeach
Copy link

@epeach epeach commented Jul 25, 2018

Applying style fixes from July 20, bug bash.

Changes:
*Fix regression where submit button and date move the left and on different lines.
*Disable 'Save and Submit' button when no feedback.
*Remove 'documentation' button from feedback tab for students and teachers.

Before - No Feedback
screenshot from 2018-07-25 16-04-35

Before - Submitted
screenshot from 2018-07-25 16-04-11

After - No Feedback
screenshot from 2018-07-25 15-55-56

After - Submitted
screenshot from 2018-07-25 15-56-17

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@epeach epeach merged commit 2556340 into staging Jul 26, 2018
@epeach epeach deleted the teacher-feedback-bash-style-fix branch July 30, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants