New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account page: Email and parent email bugfixes #23931

Merged

islemaster merged 2 commits into staging from show-both-email-and-parent-email

Jul 26, 2018

Contributor

islemaster commented Jul 26, 2018

Fixes two blocking bugs:

Show email even when parent email is being shown (but not if the account is parent-managed; that is, it has a parent email but no email on file).
Can update account with a blank parent email.


          Show email and parent email field if you have an email

ec1e031

islemaster requested a review from maddiedierker

July 26, 2018 18:04


          Treat blank parent email as nil (and valid)

b6f92d3

islemaster force-pushed the show-both-email-and-parent-email branch from c732527 to b6f92d3 Compare

July 26, 2018 19:12

maddiedierker approved these changes

View reviewed changes

Contributor

maddiedierker left a comment

👍 looks great! there's a merge conflict, but the logic is good

islemaster merged commit bd3fbd6 into staging

islemaster deleted the show-both-email-and-parent-email branch

July 26, 2018 20:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment