Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links on educate/csp/widgets #23953

Merged
merged 1 commit into from Jul 27, 2018
Merged

Update links on educate/csp/widgets #23953

merged 1 commit into from Jul 27, 2018

Conversation

balderdash
Copy link
Contributor

@balderdash balderdash commented Jul 27, 2018

Fixing a bunch of links to point to the 2018 versions of lessons and lesson plans. Some are currently out of date, but others are completely broken. Pointed out by GT.

@balderdash balderdash requested a review from epeach July 27, 2018 18:22
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - quick question about some links that are removed rather than updated.

%i.fa.fa-external-link-square
%a{href: CDO.studio_url('/s/cspunit2/stage/13/puzzle/1'), target:'_blank'}
Caesar Cipher Stage in CS Principles
%li
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have corresponding links to the Caesar Cipher and Frequency Analysis Units?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're no longer using the Frequency Analysis part, so GT just wanted me to drop those. The new links point to the Caesar Cipher widget, but now that there's just one set of links in that section we can make the link text the same as the other units.

@balderdash balderdash merged commit 8eb895f into staging Jul 27, 2018
@balderdash balderdash deleted the 2018-updates branch July 31, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants