I18n sync Down & Out 07/30 #23991
I18n sync Down & Out 07/30 #23991
Conversation
| sample4_failure_message_override: Congratulations! You gathered X coins! | ||
| sample6_failure_message_override: Not quite. Keep trying! [Move to Play Zone] | ||
| sample8_failure_message_override: Congratulations! You gathered X coins! | ||
| el: |
There was a problem hiding this comment.
This file went blank. Guessing this is fine since we didn't lose any translations and we fallback to the source en file?
There was a problem hiding this comment.
Yep! Ram did a bunch of work last week to verify that fallbacks should always work
| @@ -10,26 +10,26 @@ | |||
| "COLLAPSE_BLOCK": "Bloku yığ", | |||
| "COLOUR_BLEND_COLOUR1": "rəng 1", | |||
| "COLOUR_BLEND_COLOUR2": "rəng 2", | |||
| "COLOUR_BLEND_HELPURL": "http://meyerweb.com/eric/tools/color-blend/", | |||
| "COLOUR_BLEND_HELPURL": "", | |||
There was a problem hiding this comment.
Did we lose all these links because of sanitization?
There was a problem hiding this comment.
Or just so happens these are links but it's because they're not translated they're skipped like the rest? Should these even be in the i18n pipeline since they're only URLs and no string content?
There was a problem hiding this comment.
Yeah, these are skipped only because they're not translated. It probably doesn't make sense for them to be in the pipeline in the first place, but at least now they're not cluttering up the locales directory!
| @@ -56,7 +56,7 @@ | |||
| "pathRight": "əgər sağa yol varsa,", | |||
| "pilePresent": "təpəcik var", | |||
| "playSoundBounce": "sıçrayış səsi çıxart", | |||
| "playSoundCheer": "play cheering sound", | |||
| "playSoundCheer": "", | |||
There was a problem hiding this comment.
How come some files we'll show a blank string? But others we'll remove the key too? Or is the Greek file an exception/bug?
There was a problem hiding this comment.
This is just the way crowdin does it; it looks like yml files remove the key and json files just drop it down to an empty string.
I'm eventually going to look into adding a step to our out sync to remove these, but they're harmless.
|
Yep, everything here has been well-tested. And of course, all the blank/missing strings are just untranslated English strings, so although it's a big negative diff we're actually losing literally zero data. |
Regular sync out, but now with Crowdin's "skip untranslated strings" option enabled!
Depends on #23948