Rename instructions fields in apps code #24076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
rename-instructions
branch
from
5000ab0
to
fcb9a07
Compare
Hamms
force-pushed
the
rename-instructions
branch
from
e48bbce
to
5bda0e5
Compare
Hamms
changed the title
Hamms
force-pushed
the
rename-instructions
branch
from
5bda0e5
to
2aed19b
Compare
balderdash
approved these changes
Aug 7, 2018
apps/src/bounce/bounce.js
Outdated
| config.level.markdownInstructions && | ||
| !config.level.instructions | ||
| config.level.longInstructions && | ||
| !config.level.shortInstructions | ||
| ) { | ||
| // if we are an embedded level with markdown instructions but no regular |
There was a problem hiding this comment.
Worth updating this comment? It's been copied to a few other places as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the process to rename
instructions > shortInstructionsandmarkdownInstructions > longInstructionseverywhere in our system: apps