Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed hardcoded textarea symbol #24136

Merged
merged 2 commits into from Aug 7, 2018
Merged

Fixed hardcoded textarea symbol #24136

merged 2 commits into from Aug 7, 2018

Conversation

MeyAyre
Copy link
Contributor

@MeyAyre MeyAyre commented Aug 7, 2018

The symbol assigned to the textarea was hardcoded as start_blocks. Changed this in the _collapsible_block_editor partial to use xml_id variable.

@MeyAyre MeyAyre requested a review from Hamms August 7, 2018 15:27
Hamms
Hamms approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MeyAyre MeyAyre merged commit 48080db into staging Aug 7, 2018
@balderdash balderdash deleted the collapse-editors-patch branch September 20, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MeyAyre @Hamms