Refactor dependent user destroy #24178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #24168.
I was originally thinking that we would make an AJAX request to
GET /users/to_destroyin order to expose those users to the teacher in the new account deletion flow, and now I'm realizing that that's not necessary.Now, there is a
dependent_studentsmethod on user that is available in the script data inregistrations/edit.html.hamlfor our React components (DeleteAccount.jsxand children) to consume. This will also replacedependedUponForLogin.Follow-up Work
Once this change has been deployed and is available for front-end consumption (wanted to make a parallel change since front-ends get deployed slightly after back-ends), I will render the contents of
dependentStudentswhen a teacher is deleting their account.