Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up the Dance.* interpreted API the same place as other p5 init #24328

Merged
merged 1 commit into from Aug 16, 2018
Merged

Set up the Dance.* interpreted API the same place as other p5 init #24328

merged 1 commit into from Aug 16, 2018

Conversation

joshlory
Copy link
Contributor

Address code review feedback in PR #24268.

@joshlory joshlory requested a review from Hamms August 16, 2018 17:29
Hamms
Hamms approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@joshlory joshlory merged commit d3d621e into staging Aug 16, 2018
@joshlory joshlory deleted the move-dance-init branch August 16, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlory @Hamms