Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contact rollups to use users_view #24380

Merged
merged 1 commit into from Aug 18, 2018
Merged

Fix contact rollups to use users_view #24380

merged 1 commit into from Aug 18, 2018

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Aug 17, 2018

contact rollups was recently updated to support users configured for multi-auth by querying a view on the users and authentication_options tables. Some code was not fully updated to use the view, causing contact rollups to fail.

ewjordan
ewjordan approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@ewjordan ewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Took a quick scan through the rest, and while it's a little tricky to easily see whether the rest are correct (in a lot of situations I wrote FROM users_view as users, and left the users.* alone), I think the others look good.

Thanks!

@sureshc sureshc merged commit 24b0696 into staging Aug 18, 2018
@sureshc sureshc deleted the fix-contact-rollups-to-use-users-view branch August 18, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjordan ewjordan ewjordan approved these changes

@jeremydstone jeremydstone Awaiting requested review from jeremydstone

Assignees
No one assigned
Labels
bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sureshc @ewjordan