User purge: Wrap user purge in a Pegasus transaction #24381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using a dashboard transaction before but realized pegasus uses a separate db connection so the dashboard transaction wouldn't apply to pegasus db changes made during user purge. We now wrap the purge operations in both transactions. I've written a test that does some minimal validation that the transactions are behaving as expected. I'm open to suggestions on better validation of this behavior, and it's still known that we do some things during user purge that we can't roll back (like deleting S3 content).
ewjordan
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using a dashboard transaction before but realized pegasus uses a separate db connection so the dashboard transaction wouldn't apply to pegasus db changes made during user purge. We now wrap the purge operations in both transactions.
I've written a test that does some minimal validation that the transactions are behaving as expected. I'm open to suggestions on better validation of this behavior, and it's still known that we do some things during user purge that we can't roll back (like deleting S3 content).