Stop recreating dsl i18n on every seed #24384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're now trying to be more selective about our seeding
Hamms
force-pushed
the
stop-recreating-dsl-i18n
branch
from
fc193c5
to
6dae70a
Compare
balderdash
approved these changes
Aug 17, 2018
|
Turns out this legit breaks things (details in the trello card) |
Hamms
added a commit
that referenced
this pull request
Apr 4, 2019
Repeat of #24384 This broke things the first time because we depended on content being in the dsls.en.yml file in order to render successfully; we no longer do, so it should be safe to stop this.
|
@Hamms can you pull the details out here as well? Is the issue from #24183 (comment) ? |
|
Yep! My "entirely unnecessary" comment in the PR description here turns out to be entirely untrue; it's absolutely necessary to recreate the dsl i18n on every seed because we rely on the dsl i18n not just for rendering translations, but also for rendering the English version. (My comment about this method of syncing making things harder than they need to be remains valid). I address this is #27881 by making rendering the English version work fine regardless of the state of the dsl i18n. |
|
Got it, thx for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24183, I added some logic to only sync CSF dsls i18n strings on level save. Unfortunately, I didn't realize that we also do a full dsls sync on every seed, which is both entirely unnecessary and is a method of syncing that makes it super difficult to determine whether or not the level in question is CSF.
So, I'm just going to disable that sync, and also revert
dsls.en.ymlback to what we expect it to be.