isolate rendering of markdown into a single React component #24394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
isolate-markdown-rendering
branch
from
af5cdd4
to
d9f058c
Compare
Hamms
force-pushed
the
isolate-markdown-rendering
branch
from
d9f058c
to
1da5e80
Compare
Hamms
changed the title
joshlory
reviewed
Aug 21, 2018
|
|
||
| render() { | ||
| const processedMarkdown = processMarkdown(this.props.markdown, { renderer }); | ||
| /* eslint-disable react/no-danger */ |
There was a problem hiding this comment.
I worry a little bit about hiding this warning inside a slick wrapper — consumers may not realize the markdown prop is vulnerable to unsafe HTML. I wonder if we should call this UnsafeRenderMarkdown for clarity, until we start limiting what markup can be rendered?
|
Love the approach! One question about sharp edges / foot-guns. |
joshlory
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A component that currently uses
markedfor markdown rendering, but will eventually be updated to use remark.