Remove email validation in ChangeUserTypeModal #24411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #24364.
Removes validation that requires the user to input an existing email address when upgrading from student to teacher.
What does this mean?
Non-migrated users can now input an email address that does not match their existing address, but will get a server error rather than a front-end validation error (image below)
Migrated users can input an email address that does not match any of their existing email addresses and the request will succeed (it creates a new email
AuthenticationOptionor grabs an existing option with the matching email and makes it their primary)