Fix bug where migrated students in rostered sections with passwords get delete… #24420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d with teacher
Students that met the following requirements were incorrectly being deleted with teacher accounts:
AuthenticationOptionIf a student meets the above requirements but they also have a password, they should not be deleted. This PR fixes the condition where students were being deleted whether or not they had a password.
This isn't a huge deal at this point because it only applies to migrated students, and no users have been migrated yet. (Although it could have been!)
This was a misunderstanding in the requirements on my part, as I explicitly was not checking
encrypted_passwordfor migrated students.