Record Audio - Timeout and Visualizer #24457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
reviewed
Aug 24, 2018
| @@ -104,6 +122,12 @@ export default class AudioRecorder extends React.Component { | |||
| <div style={styles.buttonRow}> | |||
|
|
|||
| <input type="text" placeholder="mysound1.mp3" onChange={this.onNameChange} value={this.state.audioName}/> | |||
| {this.state.recording && | |||
| <span style={assetButtonStyles.button}> | |||
| <i style={{color: 'red', margin: 5}} className="fa fa-circle"/> | |||
There was a problem hiding this comment.
Especially since you already have style object in this file, let' remove the in-line styles here.
Erin007
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Add a 30-second timeout to the record-audio feature.
*Add 'Recording' text and icon to make it clear when recording is happening. See below screenshots.
Before Recording:
While Recording:
