Do not parse/yield Clever API response if error occurs #24475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks for fixing my old bug 😄 (introduced in commit 7ce5e09). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pair @ewjordan.
Related to this Honeybadger error.
Rails'
rendermethod does not return from the method it is called from (related double-rendering error from Rails docs), when an error would occur in the GET request to Clever, the error would be rendered, but we were still trying to parse and yield the failed response, which isnilin the case of an error.This makes sure that we only parse/yield the response upon a successful response from the Clever API.