Import AWS.Firehose, not of all of aws-sdk #24476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you document what you used to generate those size audits somewhere? I wonder if would be possible to add something like that to our CI tests; I'd love to get notified if a PR of mine has a significant impact on the bundle size. |
Hamms
approved these changes
Aug 27, 2018
|
Documentation added in #24504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-sdkis the single largest part of our code-studio-common bundle, even though we only use it for logging data to firehose:This PR changes the way we import
AWS.Firehoseto only bring in the relevant parts, eliminating a bunch of unused library code:Tested this change locally (overriding the check that disables firehose logging in dev environments).