Kick @code-dot-org/johnny-five out of the code-studio-common bundle #24478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use johnny-five in the maker toolkit, so it should live in the applab.js bundle. Instead, it's taking up a bunch of space in code-studio-common:
It got there because the shared toolbox settings cog checks if maker toolkit is enabled, and in doing so requires all the maker toolkit code. This PR moves the
maker.isEnabled
/maker.isAvailable
methods to the maker toolkit redux module (which is where that enabled/available information comes from anyway) to break that dependency and move johnny-five back to the applab.js bundle.