gracefully handle null assessment id #24525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Aug 29, 2018
| @@ -637,7 +637,7 @@ export const countSubmissionsForCurrentAssessment = (state) => { | |||
| const studentResponses = getAssessmentResponsesForCurrentScript(state); | |||
| let totalSubmissions = 0; | |||
| Object.values(studentResponses).forEach((student) => { | |||
| if (Object.keys(student.responses_by_assessment).includes(currentAssessmentId.toString())) { | |||
| if (Object.keys(student.responses_by_assessment).includes(currentAssessmentId + '')) { | |||
There was a problem hiding this comment.
This may be the safest change, but it seems reasonable to step back a layer and make countSubmissionsForCurrentAssessment early-out and return 0 if currentAssessmentId is undefined. It'd be an easy case to add a unit test for, too.
|
Great idea @islemaster . Please take another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://codeorg.zendesk.com/agent/tickets/206936 provides a reliable repro of assessment tab failing to load. the js error console shows the following:
which points to the following minified code:
I don't have an exact repro, but I'm pretty sure this PR will fix the immediate problem. We do a similar thing here, which fixed a similar problem that i could repro, which worked in that situation:
code-dot-org/apps/src/templates/sectionAssessments/sectionAssessmentsRedux.js
Lines 485 to 490 in 3e53918
So I'm proposing fixing the immediate problem, and then testing it out on the zendesk ticket requester's account to see if the issue is resolved.