Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects: remove un-used code to fix publish dialog #24528

Merged
merged 2 commits into from Aug 29, 2018
Merged

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Aug 29, 2018

BEFORE
Currently, if you try to publish from the PersonalProjectsTable you see a PublishDialog with a perpetual "publishing..." spinner.
screen shot 2018-08-29 at 12 46 32 am
because there is an error:
screen shot 2018-08-29 at 12 46 39 am
The error occurs because we are handling all of the publishing via projectsRedux and no longer need these functions for the Angular version of the table.

AFTER
By removing the code that causes the error, we can publish projects (only those of publishable types) from the PersonalProjectsTable.
publish

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however it seems like there's a lot of code here that's not getting any UI test coverage. Let's talk tomorrow about whether there's a simple test we can add.

@Erin007 Erin007 merged commit 0c31143 into staging Aug 29, 2018
@Erin007 Erin007 deleted the publish-dialog-fix branch August 29, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants