Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects: experiment name chevron-publish -> chevron-publish-v2 #24537

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Aug 29, 2018

There were a couple of major flaws with my initial set up for the A/B test of publishing in different ways from the PersonalProjectsTable.

1.) I was logging a 'page-load' every time the table (re)rendered rather than only when the projects page was loaded. Fixed in #24527.

2.) I timed the set up of my user based experiment on production too late based on my other changes so there was a duration where everyone was only seeing one variation.

To collect accurate data, I've updated the experiment name from chevron-publish to chevron-publish-v2 in this PR, and set up new experiments on production and staging and stopped the previous version.

staging

set up new chevron-publish-v2
screen shot 2018-08-29 at 2 57 39 pm

stop chevron-publish
screen shot 2018-08-29 at 3 18 20 pm

production

set up new chevron-publish-v2
screen shot 2018-08-29 at 3 00 13 pm

stop chevron-publish
screen shot 2018-08-29 at 3 22 43 pm

Note, there is potential for slight user bad with this change. Someone previously in one variation of the study might be randomized into the other, which could be confusing. Hopefully, publishing is straightforward enough via either UI that it won't be too disruptive - and we're about to find out which method is more discoverable!

@davidsbailey
Copy link
Member

Hi Erin, apologies for suggesting an approach which ended up being this complicated. My vision was for you to only to have to update the strings we were using to log things, but I forgot that the study name was tied to the experiment name and should have mentioned that goal more generally.

If you wanted to eliminate the user-bad you mentioned, you could append -v2 to the two study_groups instead of appending it to the study.

However, since you've already done the work of setting up the new experiment, I think its fine to proceed with what you have here. We can just remember to find a way to reset the data less disruptively next time.

@Erin007 Erin007 merged commit 9008269 into staging Aug 29, 2018
@Erin007 Erin007 deleted the chevron-publish-v2 branch August 29, 2018 21:13
@Erin007
Copy link
Contributor Author

Erin007 commented Aug 29, 2018

I also think the user bad isn’t really that bad because switching variants that the user sees is something we’ve planned for the end of the experiment anyway. Those in the “losing” variant will be switched to the “winning” one; an unlucky few might just be flipped between versions an extra time.

Thanks for the clarification, Dave! I should’ve asked more questions before I proceeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants