Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoc: a few fixes now that we're in pre-hoc mode for 2018 #24556

Merged
merged 2 commits into from Aug 30, 2018

Conversation

breville
Copy link
Member

@breville breville commented Aug 30, 2018

  • For non-US countries, show 0 in heading when no events have been created in that country yet.
  • Send Spanish response email to more countries (as specified by users in hoc sign-up form).
  • When listing events by name, choose the first of organization name, NCES-based school name, or manually-entered school name, that isn't blank.

Follows the work of #24470.

- For non-US countries, show 0 in heading when no events have been created in that country yet.
- Send Spanish response email to more countries (as specified by users in hoc sign-up form).
- When listing events by name, choose the first of organization name, NCES-based school name, or manually-entered school name, that isn't blank.
@breville breville requested a review from Erin007 August 30, 2018 16:01
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@breville breville merged commit 0f164d4 into staging Aug 30, 2018
@breville breville deleted the hoc-site-fixes branch August 30, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants