Add padding to all <details> tags in markdown instructions
#24574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
changed the title
<details> tags in markdown instructions<details> tags in markdown instructions
balderdash
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commonmark, in order to include markdown within html components, you must make sure to pad the markdown with newlines:
https://spec.commonmark.org/0.18/#example-108
Marked, unfortunately, will parse HTML content into markdown indiscriminately. We rely quite heavily on this functionality, mostly in the
<details>tags that are used throughout CSD and CSP. This PR simply goes through and adds the necessary padding to all those instances, so they will render the same in both commonmark and marked.I recommend reviewing with
git diff --word-diff-regex=.