Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form maps: set max width of popup content for maps #24596

Merged
merged 1 commit into from Sep 1, 2018

Conversation

breville
Copy link
Member

On https://code.org/volunteer/local and https://code.org/learn/local the popup content inside the map could end up being too wide. Now, we set a maximum width for each piece of content inside that popup.

/volunteer/local

before

screenshot 2018-08-31 09 45 13

after

screenshot 2018-08-31 09 44 56

/learn/local

before

screenshot 2018-08-31 10 10 38

after

screenshot 2018-08-31 10 10 53

On https://code.org/volunteer/local and https://code.org/learn/local the popup content inside the map could end up being too wide.  Now, we set a maximum width for each piece of content inside that popup.
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! And thanks for moving the css to its own file - hooray!

@breville breville merged commit 4f9b42a into staging Sep 1, 2018
@breville breville deleted the form-maps-make-popup-narrower branch September 1, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants