Add new microsoft_v2_auth provider for devise #24600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Aug 31, 2018
| @@ -1029,4 +1037,4 @@ RUBY VERSION | |||
| ruby 2.5.0p0 | |||
|
|
|||
| BUNDLED WITH | |||
| 1.16.1 | |||
| 1.16.2 | |||
There was a problem hiding this comment.
Is it expected that we're bumping the patch version? Probably not an issue, just double-checking.
There was a problem hiding this comment.
this was not intentional, so i'm not sure why the version was bumped. my local version is 1.16.2, so maybe when i added the new gem and bundled, it bumped the version?
ewjordan
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the omniauth-microsoft_v2_auth gem in order to authenticate all Microsoft account types, since our current gem (omniauth-windowslive) does not work for Officer 365 users.
I chose this gem for a few reasons: 1) it works directly based off of Microsoft's suggested setup for Rails apps, and 2) I couldn't find any other gems that used the AAD 2.0 endpoint that we need to use for this integration.
There is a lot of follow-up needed to actually get SSO and silent takeover working for existing
windowsliveusers and new MSFT SSO users, but I wanted to get the gem/Devise setup in first to make sure all goes well.Unfortunately, it looks like I can't test this functionality locally because Microsoft requires the redirect URI to be HTTPS and our localhost uses HTTP:
