Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record Audio - WebLab fix #24624

Merged
merged 4 commits into from Sep 5, 2018
Merged

Record Audio - WebLab fix #24624

merged 4 commits into from Sep 5, 2018

Conversation

epeach
Copy link

@epeach epeach commented Sep 4, 2018

In WebLab, when selecting to add an image, the record-audio option appears in the subsequent dialog. You can record audio, but because it is not one of the permitted file types, after you save it, it disappears.

This fix adds a boolean to disable displaying the record-audio button in the manage assets dialog.

Includes test.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely implemented and tested!

@epeach epeach merged commit 1c401fd into staging Sep 5, 2018
@epeach epeach deleted the record-audio-weblab-fix branch September 14, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants