Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Moderation: temporarily don't increment abuse score #24626

Merged
merged 3 commits into from Sep 5, 2018

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Sep 4, 2018

We are going to re-enable content moderation (follow up to work that was started this spring, such as #21812), but will be adjusting the thresholds in a series of trials to optimize for identifying inappropriate images without incorrectly flagging appropriate images. In the meantime, we don't want to increment abuse score until we identify the optimal threshold because we don't want to increase abuse scores erroneously for projects that are appropriate. App Lab and Game Lab non-featured projects are still hidden in the public project gallery for users who do not have project_validator permissions; therefore any potential inappropriate projects which would've otherwise had their abuse score incremented will still remain hidden from the public gallery.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks great!

@@ -10,62 +10,6 @@ def setup
Aws::S3::Client.expects(:new).never
end

def test_adult_thumbnail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this situation it may be preferable to use skip.

def test_adult_thumbnail
  skip 'Disabled while we gather Azure moderation stats. (PR 24626)'
  # ...rest of test...
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I always forget that I can do that. Thanks.

@Erin007 Erin007 merged commit c6a08bc into staging Sep 5, 2018
@Erin007 Erin007 deleted the dont-use-content-mod-results branch September 5, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants