Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up XML block editors within the editor #24653

Merged
merged 1 commit into from Sep 13, 2018
Merged

Conversation

MeyAyre
Copy link
Contributor

@MeyAyre MeyAyre commented Sep 5, 2018

Changes:

  • Removed unnecessary code that brought the XML block editors up if the level wasn't a droplet level. Now that droplet and blockly code live happily in their own partials there's no need for checks like this anymore.
  • Moved the solution block xml editor to the same area as the other xml block editors.
  • Made XML block editors collapsed by default (Requested by Mike Harvey)

Before:
image
image
image
image

After:
image

@MeyAyre MeyAyre requested a review from Hamms September 6, 2018 18:18
@Hamms
Copy link
Contributor

Hamms commented Sep 6, 2018

Why are some of the arrows in the "after" screenshot up, and some down?

@MeyAyre
Copy link
Contributor Author

MeyAyre commented Sep 7, 2018

@Hamms This is something that's been happening with the arrows. They sort of arbitrarily change direction when you click on the collapse trigger.

Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's not super helpful of them. Are you tracking levelbuilder issues anywhere? If so, we should add the arrows problem to that list. If not .... we probably should be.

@MeyAyre MeyAyre merged commit 866312c into staging Sep 13, 2018
@fisher-alice fisher-alice deleted the lb-xml-block-cleanup branch July 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants